New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling for web applications which respond with non-200… #61

Merged
merged 1 commit into from Oct 21, 2017

Conversation

Projects
None yet
2 participants
@andresriancho
Contributor

andresriancho commented Oct 20, 2017

… codes

@andresriancho

This comment has been minimized.

Show comment
Hide comment
@andresriancho

andresriancho Oct 20, 2017

Contributor

Fixes #32

Contributor

andresriancho commented Oct 20, 2017

Fixes #32

@codingo

This comment has been minimized.

Show comment
Hide comment
@codingo

codingo Oct 20, 2017

Owner

Not ignoring this but I'm travelling until tomorrow so it may take a couple of days to merge

Owner

codingo commented Oct 20, 2017

Not ignoring this but I'm travelling until tomorrow so it may take a couple of days to merge

@codingo

Looks good, very happy with this. Probably would have used a smaller commit message but makes sense contextually.

@codingo codingo self-assigned this Oct 21, 2017

@codingo codingo added the enhancement label Oct 21, 2017

@codingo codingo merged commit 9bcf017 into codingo:master Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment