Test culture insensivity and bug fixes #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Mr. @rexim, currently you're the responsible reviewer, so please take a look if you can. |
| [typeof<obj>] | ||
| else tail_type | ||
| | [] -> [typeof<System.Void>] | ||
| | _ -> (gf.MakeGenerator context (List.rev body |> List.head)).ReturnTypes() |
Member
There was a problem hiding this comment.
lol, doesn't List really have last or something like that? %)
Member
Author
There was a problem hiding this comment.
Thank you, that's a good question. I'm almost sure that List module had no such function back the days of F# 2.0. But now it actually has! So I'll review the code and use it where possible. I'll create a separate issue for that.
Member
|
The requet looks fine for me. I approve it. Thanks! |
ForNeVeR
added a commit
that referenced
this pull request
Mar 16, 2016
Test culture insensivity and bug fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my quest to fix #24 I've encountered some compiler bugs regarding to the
letexpressions and have exterminated these bugs.The main problem I fixed is that
BodyGeneratorwas used both in context of a function body and in context of aletclause body. In first context its return type should be based on a function return type (as we already discussed in #26, it shouldn't return anything when compiling avoidfunction).Now the
BodyGeneratoralways receives (hopefully) the right return type definition, so the machinery added in #26 will make a good decisions about whether to return something or not.Closes #24.