Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines are broken. #68

Closed
vypxl opened this issue Nov 22, 2018 · 4 comments
Closed

Lines are broken. #68

vypxl opened this issue Nov 22, 2018 · 4 comments

Comments

@vypxl
Copy link

vypxl commented Nov 22, 2018

You can see it in the basic example "Logo Default", if you do something like fd 100 lt 90 fd 100 the corner
is not smooth. Like in |_ the first line is a little too long for the corner to be smooth.

A smooth corner can only be achieved by something like fd 99 pu fd 1 pd lt 90 fd 100.

@TheTastefulToastie
Copy link
Collaborator

@vypxl Should be fixed now 👍
Can you give it another test?

@vypxl
Copy link
Author

vypxl commented Nov 22, 2018

Yes, now it is how it should be.
But why didn't the translate and rotate approach work? Any Idea?

@TheTastefulToastie
Copy link
Collaborator

My thinking is that its some kind of rounding error accumulating in the transformation matrix.
I reckon it was the same rounding errors that meant floating point Logo wasn't working (and now does 😆).

If you select the large coding train logo and look closely at the 'The' above the 'C' some of the lines look a bit wonky because I ran into this issue then and couldn't get it to position correctly.

In theory the translate/rotate approach should work, but coalescing lots of small transformations into one matrix usually runs into these kind of problems.

@vypxl
Copy link
Author

vypxl commented Nov 22, 2018

🤔 Weird stuff, but it is solved for good hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants