Incorrect nullability on IApiRequestFormatMetadataProvider.GetSupport… dotnet#62935

Author: codingwithstephen

src/Http/Routing/test/UnitTests/Builder/RouteHandlerEndpointRouteBuilderExtensionsTest.cs

@@ -1103,7 +1103,7 @@ class FromRoute : Attribute, IFromRouteMetadata
 
     class TestConsumesAttribute : Attribute, IAcceptsMetadata
     {
-        public TestConsumesAttribute(Type requestType, string? contentType, params string[] otherContentTypes)
+        public TestConsumesAttribute(Type requestType, string contentType, params string[] otherContentTypes)
         {
             ArgumentNullException.ThrowIfNull(contentType);
 

src/Middleware/HttpLogging/src/MediaTypeOptions.cs

@@ -47,7 +47,7 @@ internal void AddText(MediaTypeHeaderValue mediaType)
     /// If charset is not specified in the contentType, the encoding will default to UTF-8.
     /// </remarks>
     /// <param name="contentType">The content type to add.</param>
-    public void AddText(string? contentType)
+    public void AddText(string contentType)
     {
         ArgumentNullException.ThrowIfNull(contentType);
 
@@ -59,7 +59,7 @@ public void AddText(string? contentType)
     /// </summary>
     /// <param name="contentType">The content type to add.</param>
     /// <param name="encoding">The encoding to use.</param>
-    public void AddText(string? contentType, Encoding encoding)
+    public void AddText(string contentType, Encoding encoding)
     {
         ArgumentNullException.ThrowIfNull(contentType);
         ArgumentNullException.ThrowIfNull(encoding);

src/Mvc/Mvc.Core/src/ConsumesAttribute.cs

@@ -36,7 +36,7 @@ public class ConsumesAttribute :
     /// <param name="contentType">The request content type.</param>
     /// <param name="otherContentTypes">The additional list of allowed request content types.</param>
     /// </summary>
-    public ConsumesAttribute(string? contentType, params string[] otherContentTypes)
+    public ConsumesAttribute(string contentType, params string[] otherContentTypes)
     {
         ArgumentNullException.ThrowIfNull(contentType);
 
@@ -59,7 +59,7 @@ public ConsumesAttribute(string? contentType, params string[] otherContentTypes)
     /// <param name="contentType">The request content type.</param>
     /// <param name="otherContentTypes">The additional list of allowed request content types.</param>
     /// </summary>
-    public ConsumesAttribute(Type requestType, string? contentType, params string[] otherContentTypes)
+    public ConsumesAttribute(Type requestType, string contentType, params string[] otherContentTypes)
     {
         ArgumentNullException.ThrowIfNull(contentType);
 

src/Mvc/Mvc.Core/src/FileResult.cs

@@ -19,7 +19,7 @@ public abstract class FileResult : ActionResult
     /// the provided <paramref name="contentType"/>.
     /// </summary>
     /// <param name="contentType">The Content-Type header of the response.</param>
-    protected FileResult(string? contentType)
+    protected FileResult(string contentType)
     {
         ArgumentNullException.ThrowIfNull(contentType);
 

src/Mvc/Mvc.Core/src/Formatters/FormatterMappings.cs

@@ -21,7 +21,7 @@ public class FormatterMappings
     /// </summary>
     /// <param name="format">The format value.</param>
     /// <param name="contentType">The media type for the format value.</param>
-    public void SetMediaTypeMappingForFormat(string format, string? contentType)
+    public void SetMediaTypeMappingForFormat(string format, string contentType)
     {
         ArgumentNullException.ThrowIfNull(format);
         ArgumentNullException.ThrowIfNull(contentType);
@@ -35,7 +35,7 @@ public void SetMediaTypeMappingForFormat(string format, string? contentType)
     /// </summary>
     /// <param name="format">The format value.</param>
     /// <param name="contentType">The media type for the format value.</param>
-    public void SetMediaTypeMappingForFormat(string format, MediaTypeHeaderValue? contentType)
+    public void SetMediaTypeMappingForFormat(string format, MediaTypeHeaderValue contentType)
     {
         ArgumentNullException.ThrowIfNull(format);
         ArgumentNullException.ThrowIfNull(contentType);

src/Mvc/Mvc.Core/src/Formatters/InputFormatter.cs

@@ -118,7 +118,7 @@ public virtual Task<InputFormatterResult> ReadAsync(InputFormatterContext contex
     public abstract Task<InputFormatterResult> ReadRequestBodyAsync(InputFormatterContext context);
 
     /// <inheritdoc />
-    public virtual IReadOnlyList<string>? GetSupportedContentTypes(string contentType, Type objectType)
+    public virtual IReadOnlyList<string>? GetSupportedContentTypes(string? contentType, Type objectType)
     {
         if (SupportedMediaTypes.Count == 0)
         {

src/Mvc/Mvc.Core/src/ProducesResponseTypeAttribute.cs

@@ -45,7 +45,7 @@ public ProducesResponseTypeAttribute(Type type, int statusCode)
     /// <param name="statusCode">The HTTP response status code.</param>
     /// <param name="contentType">The content type associated with the response.</param>
     /// <param name="additionalContentTypes">Additional content types supported by the response.</param>
-    public ProducesResponseTypeAttribute(Type type, int statusCode, string? contentType, params string[] additionalContentTypes)
+    public ProducesResponseTypeAttribute(Type type, int statusCode, string contentType, params string[] additionalContentTypes)
     {
         ArgumentNullException.ThrowIfNull(contentType);