Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ProgressBar #562

Merged
merged 6 commits into from Oct 19, 2023
Merged

Fixed ProgressBar #562

merged 6 commits into from Oct 19, 2023

Conversation

seog-jun
Copy link
Contributor

Fixes #551

✨ Codu Pull Request 💻

Codu Logo

👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈

Pull Request details:

  • Used NextTopLoader component as the current ProgressBar component is broke(Next.js 13 doesn't support router.events.on/off anymore)
  • Added a new CSS gradient to apply the gradient to NextTopLoader

Any Breaking changes:

  • None

Associated Screenshots:

ProgressBar.mp4

@vercel
Copy link

vercel bot commented Oct 18, 2023

@seog-jun is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 7:18pm

@NiallJoeMaher
Copy link
Contributor

Do you have any ideas on why when I go to the homepage, it doesn't do the full animation?

The other pages seem to be fine. 🤔

Screen.Recording.2023-10-19.at.08.32.32.mov

@seog-jun
Copy link
Contributor Author

seog-jun commented Oct 19, 2023

@NiallJoeMaher Well, I don't really see that issue from my end, but I put the linear for the same speed when loading. Please let me know if you still can see the issue.

Codu.-.The.Web.Developer.Community.-.Google.Chrome.2023-10-19.06-31-43.online-video-cutter.com.mp4

Copy link
Contributor

@NiallJoeMaher NiallJoeMaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the unused progress bar and package if we no longer are using it? Thanks! 🌮

@seog-jun
Copy link
Contributor Author

@NiallJoeMaher For sure!

@seog-jun
Copy link
Contributor Author

@NiallJoeMaher Could you please review the PR again? I'd appreciate that!

Copy link
Contributor

@NiallJoeMaher NiallJoeMaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@NiallJoeMaher NiallJoeMaher merged commit 25c1dc3 into codu-code:develop Oct 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the progress bar for when screens are loading
2 participants