New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Tests #68

Closed
codyogden opened this Issue Oct 18, 2018 · 5 comments

Comments

4 participants
@codyogden
Owner

codyogden commented Oct 18, 2018

I have only minimal experience writing code tests in React. Not sure if it is worth it for a project this small, but it would be interesting to see some basic code tests implemented.

Open to suggestions, but I'm not setting expectations or assumptions. I may try to do this myself.

@OuKevin

This comment has been minimized.

Contributor

OuKevin commented Oct 19, 2018

i'll get the test environment setup as well as implementing a few tests.

@codyogden codyogden added this to the Version 0.5.0 milestone Oct 19, 2018

@ngtungngo

This comment has been minimized.

ngtungngo commented Oct 19, 2018

I would like to add jest in this

@codyogden

This comment has been minimized.

Owner

codyogden commented Oct 19, 2018

@OuKevin That's awesome! Thank you!!

@ngtungngo That's great! I've done just tiny amounts with testing in React and Jest, but it'd be cool for someone else to apply some tests so that I may watch & learn. 😄

@mlukjanska

This comment has been minimized.

mlukjanska commented Oct 21, 2018

@codyogden Had some fun adding the tests :) Turns out it's not that easy with styled components - details in the pull request above. Btw - cool project.

@codyogden

This comment has been minimized.

Owner

codyogden commented Oct 21, 2018

@mlukjanska Your PR is amazing! I'll leave a comment there about merging, but thank you so much for your testing contributions. 💯 🙌 🙇

@codyogden codyogden closed this Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment