Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line_SetFlags implementation (See Comment!) #487

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@RockstarRaccoon
Copy link
Contributor

RockstarRaccoon commented May 23, 2018

NOTE: Please look at the way I did this before you accept it, because while I find it to be an efficient implementation, you might look at it and be like "no fucking way are we letting the mapper have DIRECT CONTROL over an internal variable from a line special."

Alternatively, you may also want to change the special number, possibly to make it available in a non-UDMF format...

That said...
This is an implementation of a Line_SetFlags special as mentioned in the following threads...
https://forum.zdoom.org/viewtopic.php?f=15&t=59808&start=15#p1044417
https://forum.zdoom.org/viewtopic.php?f=15&t=60315&p=1055471#p1050959
It works by simply taking a line tag, a set of flags to set, and a set of flags to unset, all of which basically correspond directly to the internal mapping of said flags.

RockstarRaccoon and others added some commits May 22, 2018

@coelckers

This comment has been minimized.

Copy link
Owner

coelckers commented May 23, 2018

Please learn to make clean PR's. This contains some extraneous commits that would pollute the commit history.
Aside from that, in its current form this is not usable because not all flags may be set by the mapper.

@coelckers coelckers closed this May 23, 2018

@RockstarRaccoon

This comment has been minimized.

Copy link
Contributor Author

RockstarRaccoon commented May 23, 2018

Right, and I realized while looking at some other feature requests that those flags may need to be split between two uint32s at some point surprisingly soon, so this isn't a good setup for that reason alone. I'll go back and fix the implementation and clean up the PR thing (still learning to use Git stuff), and submit something better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.