New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tags for Doom and Heretic monsters #512

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@mmaulwurff
Contributor

mmaulwurff commented Jun 24, 2018

Why? So mods that reveal enemy names don't show internal monster class names.

Tags are based on language.enu lump obituaries.

@coelckers

Since this is supposed for printing it's better not to make the names all-capitals. There are fonts that contain both uppercase and lowercase letters, just look at the console font as an example.
The names should reflect that.

@alexey-lysiuk

Could you please squash all changes to one commit?

add tags for Doom and Heretic monsters
Why? So mods that reveal enemy names don't show internal monster class names.

Tags are based on language.enu lump:
- Tags for Doom/Doom 2 monsters are referring directly to CC_* strings.
- Tags for Heretic monsters are based on obituaries.
- All tags match corresponding obituaries.
@mmaulwurff

This comment has been minimized.

Contributor

mmaulwurff commented Jun 25, 2018

Done (not without a misstep or two in the process).

@coelckers coelckers merged commit 97aba0c into coelckers:master Jun 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment