Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructible geometry: GZDoom part #611

Closed
wants to merge 1 commit into from

Conversation

jewalky
Copy link
Contributor

@jewalky jewalky commented Oct 30, 2018

This is a complex PR. Details can be found here: https://forum.zdoom.org/viewtopic.php?f=59&t=62420

@ZippeyKeys12
Copy link
Contributor

Woah, interesting idea. Portals are hell on earth.

Copy link
Member

@coelckers coelckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from the forum post:

Can you please reorganize this that it isn't scattered throughout the code? This is such a complex and extensive features that all related code should be in its own file so that they are easier to find later. Also, after doing that, please squash the commits into one.

This looks like something that will most likely be extended later, and nobody wants to hunt for all the code involved.

@coelckers
Copy link
Member

I merged this into a local work branch for evaluation. Closed so that nobody merges it while I'm working on this code.

@coelckers coelckers closed this Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants