Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export P_GetOffsetPosition and ADynamicLight::SetOffset to ZScript #668

Merged
merged 1 commit into from Dec 20, 2018
Merged

Export P_GetOffsetPosition and ADynamicLight::SetOffset to ZScript #668

merged 1 commit into from Dec 20, 2018

Conversation

Cacodemon345
Copy link
Contributor

Exports to ZScript:

  1. P_GetOffsetPosition: Useful for people writing their own functions utilizing LineTrace to spawn objects.
  2. ADynamicLight::SetOffset: Useful for people wanting to set offsets for Actor-Based Dynlights.

Copy link
Member

@coelckers coelckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add support for direct native JIT calls right away.

Copy link
Collaborator

@alexey-lysiuk alexey-lysiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave empty lines around new code. They exist to improve readability.

@Cacodemon345
Copy link
Contributor Author

Cacodemon345 commented Dec 20, 2018

Please add support for direct native JIT calls right away. I can't seem to use DEFINE_ACTION_FUNCTION_NATIVE it seems. Using it causes a compile error. I still need to find the issue.
Please leave empty lines around new code. They exist to improve readability.Sure.
Edit: Found that I have to make a new, separate method.

@Cacodemon345
Copy link
Contributor Author

Done.

Copy link
Collaborator

@alexey-lysiuk alexey-lysiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And to be honest, I would do unrelated changes in different commits.

src/portal.cpp Show resolved Hide resolved
wadsrc/static/zscript/shared/dynlights.txt Show resolved Hide resolved
@@ -28,7 +28,8 @@ class DynamicLight : Actor native
ColorFlickerLight,
RandomColorFlickerLight
};

native void SetOffset(Vector3 offset);

Default
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for being harsh, but are you kidding? There should be no removed lines, only two added, one with declaration and one empty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no removed lines, only two added, one with declaration and one empty.It's already the case.

@Cacodemon345
Copy link
Contributor Author

Direct native JIT calls are now in.

@coelckers coelckers merged commit 789941f into ZDoom:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants