New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export P_GetOffsetPosition and ADynamicLight::SetOffset to ZScript #668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add support for direct native JIT calls right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave empty lines around new code. They exist to improve readability.
|
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And to be honest, I would do unrelated changes in different commits.
@@ -28,7 +28,8 @@ class DynamicLight : Actor native | |||
ColorFlickerLight, | |||
RandomColorFlickerLight | |||
}; | |||
|
|||
native void SetOffset(Vector3 offset); | |||
|
|||
Default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for being harsh, but are you kidding? There should be no removed lines, only two added, one with declaration and one empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no removed lines, only two added, one with declaration and one empty.
It's already the case.
Direct native JIT calls are now in. |
Exports to ZScript: