Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for software renderers' corrupted picture with Vulkan backend #833

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
3 participants
@alexey-lysiuk
Copy link
Collaborator

commented May 8, 2019

Vulkan hardware buffer for software canvas may have some padding
Software renderers should be aware of buffer's pitch in order to copy pixels properly

https://forum.zdoom.org/viewtopic.php?t=64562

- fixed output of software renderers with Vulkan backend
Vulkan hardware buffer for software canvas may have some padding
Software renderers should be aware of buffer's pitch in order to copy pixels properly

https://forum.zdoom.org/viewtopic.php?t=64562
@coelckers

This comment has been minimized.

Copy link
Owner

commented May 8, 2019

Is there really no way to retrieve the actual line pitch? I cannot imagine that the Vulkan API is really this idiotic.

@coelckers coelckers requested a review from dpjudas May 8, 2019

@alexey-lysiuk

This comment has been minimized.

Copy link
Collaborator Author

commented May 8, 2019

Even if it is, this doesn't make this change any simpler. Software renderers have no notion of destination buffer's pitch as they expect contiguous memory space.

@dpjudas

This comment has been minimized.

Copy link
Collaborator

commented May 8, 2019

The PR itself looks fine to me. About how to retrieve the pitch, I actually fear that Vulkan is really this stupid. At least I haven't been able to find a way to retrieve the pitch.

@dpjudas

dpjudas approved these changes May 8, 2019

@coelckers

This comment has been minimized.

Copy link
Owner

commented May 8, 2019

What moron writes such an API? This is a surefire way for lots and lots of broken software.

@alexey-lysiuk alexey-lysiuk merged commit 56557a1 into coelckers:master May 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexey-lysiuk alexey-lysiuk deleted the alexey-lysiuk:vk_software_pitch branch May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.