Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Hint Option Menu item #837

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@mmaulwurff
Copy link
Contributor

commented May 11, 2019

Hint is a static text that is visible only if the items above are selected.
The number of items above is configurable, and by default is 1.

Hint Demo: https://www.mediafire.com/file/4p1s087fpsv28fb/hint-demo.pk3/file

@alexey-lysiuk
Copy link
Collaborator

left a comment

I’m not quite sure that this class should be in the core scripts.


int aboveBegin = aboveEnd - mAboveNumber + 1;
int selected = desc.mSelectedItem;
console.printf("selected: %d", selected);

This comment has been minimized.

Copy link
@alexey-lysiuk

alexey-lysiuk May 11, 2019

Collaborator

Please remove this line.

This comment has been minimized.

Copy link
@mmaulwurff

mmaulwurff May 11, 2019

Author Contributor

Done.

@mmaulwurff mmaulwurff force-pushed the mmaulwurff:option-menu-hint branch from c124b2b to e575261 May 11, 2019

@mmaulwurff

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

Some mods start to use hints in their menus (for example, Nash's Gore Mod: https://forum.zdoom.org/viewtopic.php?f=46&t=62641#p1080654). This means that this kind of feature is useful for modders.

There was a request for this in Brainstorming a GZDoom menu revamp (https://forum.zdoom.org/search.php?keywords=description&t=60041&sf=msgonly), so this may be useful in engine, too.

@mmaulwurff mmaulwurff changed the title added Hint Option Menu item [WIP] added Hint Option Menu item May 11, 2019

added Hint Option Menu item
Hint is a static text that is visible only if the items above are selected.
The number of items above is configurable, and by default is 1.

@mmaulwurff mmaulwurff force-pushed the mmaulwurff:option-menu-hint branch from e575261 to a6d6141 May 11, 2019

@mmaulwurff mmaulwurff changed the title [WIP] added Hint Option Menu item added Hint Option Menu item May 11, 2019

@mmaulwurff

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

Graf Zahl

As implemented the feature is not acceptable. This isn't how hints should be handled. It cannot just be done by adding new menu entries, you'll really have to make some alteration to the menu itself and look out for how it affects customized subclasses (e.g. the flag display for the gameplay and compatibility menus.)

Noted.

@mmaulwurff mmaulwurff closed this May 12, 2019

@mmaulwurff mmaulwurff deleted the mmaulwurff:option-menu-hint branch May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.