Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install soundfonts and WOPL/WOPN banks #874

Open
wants to merge 1 commit into
base: master
from

Conversation

@vilhelmgray
Copy link
Contributor

vilhelmgray commented Jun 19, 2019

The INSTALL_SOUNDFONT_PATH cache entry is used to configure the
installation directory.

This version should resolve the issue brought up in https://forum.zdoom.org/viewtopic.php?f=7&t=65035.

Copy link
Collaborator

alexey-lysiuk left a comment

This change works for me. Although, I would like to hear the same from others as well.

@coltongit

This comment has been minimized.

Copy link
Contributor

coltongit commented Aug 28, 2019

These should work as long as GZDoom can access said directory both during install and when it;s running. What I'd also recommend is allowing the soundfont directory to be changed afterwards somehow if it isn't already possible to do so.

@vilhelmgray

This comment has been minimized.

Copy link
Contributor Author

vilhelmgray commented Aug 29, 2019

The soundfont directory is already configurable via the gzdoom.ini file under the [SoundfontSearch.Directories] section.

This patch just automates the soundfont installation into the soundfont directory, since right now you have to manually add them.

@alexey-lysiuk Have any developers mentioned issues with this patch? I am happy to fix whatever problems exist in order to get it merged.

The INSTALL_SOUNDFONT_PATH cache entry is used to configure the
installation directory.
@vilhelmgray vilhelmgray force-pushed the vilhelmgray:install_soundfonts_directories branch from 6557b97 to fa157e2 Aug 29, 2019
@MajorCooke

This comment has been minimized.

Copy link
Contributor

MajorCooke commented Oct 18, 2019

I've merged this into QZDoom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.