Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PSPF_PLAYERTRANSLATED flag #925

Open
wants to merge 7 commits into
base: master
from

Conversation

@Cacodemon345
Copy link
Contributor

Cacodemon345 commented Sep 1, 2019

This PR adds:

  1. PSPF_PLAYERTRANSLATED flag: Makes the PSprite colorized according to the user's color settings of the player.
  2. bPlayerTranslated variable: for checking whether it is colorized according to the user's color settings of the player.
Merge
Merge
Merge
Merge back.
Copy link
Collaborator

madame-rachelle left a comment

I don't see any issues with this code. However, someone else besides me should have a second look before signing off on this.

@drfrag666

This comment has been minimized.

Copy link
Contributor

drfrag666 commented Sep 1, 2019

It's not a clean branch, there are several ancient PRs and old merges. Is that really a problem?

@madame-rachelle

This comment has been minimized.

Copy link
Collaborator

madame-rachelle commented Sep 1, 2019

Ah, yes, that will have to be fixed, although doing a squash will do that automatically.

@MajorCooke

This comment has been minimized.

Copy link
Contributor

MajorCooke commented Oct 19, 2019

I've cherry picked the one commit that matters into QZDoom and ignored all the merging entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.