Level post-processor with things operations #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was extracted from LevelCompatibility class, and native code was moved accordingly
New functions cover existing interface only Unsigned integers are now used instead signed for indices and bitfields
|
This, due to the major undertaking this requires, should preferably undergo testing before it's merged. |
That is the whole point of the dev builds! |
|
My main worries with this is mod compatibility as well as the level compat patches. It'd be worth checking those over with the stuff introduced in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic level post-processing and level compatibility are separated to own classes
Ability to add/query/modify things
Sample
https://forum.zdoom.org/viewtopic.php?t=66032