Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide better text for reference input #362

Closed
MrOrz opened this issue Dec 15, 2020 · 6 comments · Fixed by #445
Closed

Provide better text for reference input #362

MrOrz opened this issue Dec 15, 2020 · 6 comments · Fixed by #445
Labels
enhancement good first issue

Comments

@MrOrz
Copy link
Member

MrOrz commented Dec 15, 2020

Discussion see 20201209 meeting note

As-is

We just instruct editors to input 「資料來源」and provide「超連結與連結說明文字」in the placeholder.

image

To-be

Title

This title should apply to website editors and the reply section below:
截圖 2020-12-15 下午1 25 03

When replyType === 'OPINIONATED':

Opinion Sources
不同意見出處

When replyType is other values:

References
資料佐證

Placeholder

One line summary
» Source URL

來源說明
» 連結網址

(Note: textarea placeholders can include line breaks. )
@ulayab
Copy link
Contributor

ulayab commented Jan 23, 2021

(舉手)

ulayab added a commit to ulayab/rumors-site that referenced this issue Jan 23, 2021
@ulayab
feat(ReferenceInput): cofacts#362 change text and translate
22c3ad2
MrOrz added a commit that referenced this issue Jan 23, 2021
@MrOrz
Merge pull request #381 from ulayab/reference-wording
1bfe124 
feat(ReferenceInput): #362 change text and translate
@MrOrz
Copy link
Member Author

MrOrz commented Jan 23, 2021

Resolved by #381 @ulayab ++

@MrOrz MrOrz closed this as completed Jan 23, 2021
@MrOrz
Copy link
Member Author

MrOrz commented Jan 23, 2021

Reopen because we want to make placeholder 2 lines

One line summary
» Source URL

來源說明
» 連結網址

@MrOrz MrOrz reopened this Jan 23, 2021
ulayab added a commit to ulayab/rumors-site that referenced this issue Jan 23, 2021
@ulayab
enhance(ReasonEditor): cofacts#362 better placeholder content
3ecaf6b
@ulayab ulayab mentioned this issue Jan 23, 2021
Merged
@ulayab
Copy link
Contributor

ulayab commented Jan 23, 2021

Reopen because we want to make placeholder 2 lines

One line summary
» Source URL

來源說明
» 連結網址

Thanks for the remind! Just make a new PR for it 🙏 #382

@MrOrz
Copy link
Member Author

MrOrz commented Jan 25, 2021

Closed in #382, kudos to @ulayab

@MrOrz MrOrz closed this as completed Jan 26, 2021
@MrOrz
Copy link
Member Author

MrOrz commented Jan 26, 2021

Reopen because the reply display should also align with To-be spec
圖片

@MrOrz MrOrz reopened this Jan 26, 2021
@MrOrz MrOrz mentioned this issue Aug 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify all occurrences of "Reference" to depend on reply type cofacts/rumors-site
2 participants
@MrOrz @ulayab