New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Pre-compilation: Remove the need for special settings #137

Open
HeyJoel opened this Issue Aug 10, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@HeyJoel
Copy link
Member

HeyJoel commented Aug 10, 2017

As per #105 view pre-compilation is supported with a couple of config settings, but it may be possible to reduce the friction here.

Firstly we may be able to use the same magic that the MvcPrecompilation project uses to create a page template and block type metadata file at build time that we can rely on to always be there no matter what pre-compilation options have been set.

Secondly we may be able to compile views in the Cofoundry package assemblies to avoid the need for the MvcRazorExcludeRefAssembliesFromPublish setting as demonstrated in this example ClassLibraryWithPrecompiledViews project.

Note that work is being done by the asp.net team to improve support for view compilation in class libraries, see razor issue 1809

@HeyJoel HeyJoel added the enhancement label Aug 10, 2017

@HeyJoel HeyJoel added this to the Backlog milestone Aug 10, 2017

@HeyJoel

This comment has been minimized.

Copy link
Member

HeyJoel commented Jun 28, 2018

ASP.NET Core 2.1 has introduced the Razor SDK that can be used to embed views in an assembly. It's not immediately clear to me if this will fix any of our issues directly as there's not great detail in the documentation at present and might take some digging and experimentation to work out how exactly a project needs to be setup and what changes need to be made to our file provider to enable the views. Here's some resources that may be useful:

@HeyJoel HeyJoel modified the milestones: Backlog, Planning (0.6+) Jun 28, 2018

@HeyJoel HeyJoel referenced this issue Jun 28, 2018

Closed

Update to .NET 2.1 #154

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment