New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET Core 2.2 #270

Closed
HeyJoel opened this Issue Oct 30, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@HeyJoel
Copy link
Member

HeyJoel commented Oct 30, 2018

It's not released yet, but we can use this issue to log any potential work:

  • StaticFilePathFormatter:We use FileVersionProvider which is in an Internal AspNetCore namespace and looking at #269 it would seem it has been moved or changed in some way.

@HeyJoel HeyJoel added the enhancement label Oct 30, 2018

@HeyJoel HeyJoel added this to the Planning (0.8+) milestone Oct 30, 2018

@HeyJoel HeyJoel modified the milestones: Planning (0.9+), 0.6 Dec 6, 2018

HeyJoel added a commit that referenced this issue Dec 6, 2018

@HeyJoel

This comment has been minimized.

Copy link
Member

HeyJoel commented Dec 6, 2018

Fixed, will be released in v0.6.

@HeyJoel HeyJoel closed this Dec 6, 2018

@HeyJoel

This comment has been minimized.

Copy link
Member

HeyJoel commented Dec 6, 2018

The verb route constraint in APIs is not respected if the compatibility version flag is set to 2.2 so I've reverted it for now. I'm reopening this and logging it here:

Routes are registered using AdminApiRouteBuilderContext and the exception that gets thrown is AmbiguousMatchException between two paths with different verbs. Regustration code:

_routeBuilder.MapRoute(
                $"Cofoundry Admin Module - {verb}: {path}",
                _adminSettings.DirectoryName + "/api/" + path,
                new { controller = controllerName, action = actionName, Area = RouteConstants.AdminAreaName },
                constraints: new RouteValueDictionary(new { httpMethod = new HttpMethodRouteConstraint(verb) })
                );

@HeyJoel HeyJoel reopened this Dec 6, 2018

HeyJoel added a commit that referenced this issue Dec 6, 2018

@HeyJoel HeyJoel closed this Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment