New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a Page Collection module #86

Closed
nengberg opened this Issue Mar 16, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@nengberg
Copy link

nengberg commented Mar 16, 2017

Okay, this is not an issue but rather a feature request.

We have the scenario where we want to link to other pages in some way. A suggested implementation would be a module for a page collection, like the Custom Entity Collection, where you can select multiple pages from the solution. When you then have a list of pages it would be great if you could query the page in some way to get additional information. What do you think?

Please let me know if you need any clarification :)

@HeyJoel HeyJoel added the enhancement label Mar 16, 2017

@HeyJoel HeyJoel self-assigned this Mar 16, 2017

@HeyJoel HeyJoel added this to the 0.1.5 milestone Mar 16, 2017

@HeyJoel

This comment has been minimized.

Copy link
Member

HeyJoel commented Mar 16, 2017

Certainly we should have a PageCollectionAttribute that works in a similar way to CustomEntityCollection that includes a picker and drag/drop ordering. A page module type based off this would also be a good idea, but in reality the implementator will want to customize the template and the view data so this might be better off as an example module that can be adapted.

I can also see that it would be good to have a module that queries pages based on other attributes such as directory or tags. We have some raw page querying functionality build in already using 'IPageRepository' based on the demands of the page listing in the admin panel but this area needs a bit more thought, which is linked to issue 12: Custom Entity Partitioning & Taxonomy. For now it would be good to at least have a sample for how this existing functionality could be used.

@nengberg

This comment has been minimized.

Copy link

nengberg commented Mar 16, 2017

Yeah, that was exactly what I meant. An attribute to be able to alter the property type. Of course the module itself should be up to the consumer to define! :)

@HeyJoel

This comment has been minimized.

Copy link
Member

HeyJoel commented Mar 22, 2017

I've added three new data model attributes:

  • PageAttribute
  • PageCollectionAttribute
  • WebDirectoryAttribute

I've also created a sample application demonstrating how to use them: Cofoundry.Samples.PageModules

Currently these changes are in pre-release so you'll need to get the changes using our pre-release feed. The package version is 0.1.5-page-data-attrib0006.

Hopefully I can push a release out in the next few days.

@HeyJoel

This comment has been minimized.

Copy link
Member

HeyJoel commented Mar 29, 2017

This is now released as part of the 0.1.5 update.

@HeyJoel HeyJoel closed this Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment