-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer formulation #24
Conversation
Reworking of network definition ... and other stories
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
==========================================
- Coverage 91.10% 88.79% -2.31%
==========================================
Files 15 23 +8
Lines 854 1071 +217
Branches 159 160 +1
==========================================
+ Hits 778 951 +173
- Misses 51 98 +47
+ Partials 25 22 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. PR looks good to me.
We should update the readme example before merging or at least very shortly after merging.
I updated the readme example. It works locally, but we should look into setting up a test for that as well.
This PR merges work from many different people.
The key item added was @fracek reworking of the network definition to include individual objects for layers and to allow for multi-dimensional inputs and outputs. It also includes reworking of other parts of the code to update them to this new foundation.
This also added gbt and some preliminary implementations of different notebooks.