New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autologin code #4

Merged
merged 2 commits into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@ammienoot
Contributor

ammienoot commented Oct 9, 2018

I think I've put the changes you made to TRU-Writer and TRU-Collector to improve the autologin user handling into this SPLOT now too. If you agree, then maybe you could merge these changes in? If I've mucked it up at all (I tested and it seemed to do what I expected it to) then please let me know and I'll fix up. It's all part of the learning!

ammienoot added some commits Oct 9, 2018

Adding in autologin code
Added in autologin code from other SPLOTS, incremented version to 0.9
@cogdog

This comment has been minimized.

Show comment
Hide comment
@cogdog

cogdog Oct 9, 2018

Owner

Very cool, you might be the very first person to actually submit a real code update. Will look it over in my morning, but I'm seeing about all the files listed that would need updates.

Owner

cogdog commented Oct 9, 2018

Very cool, you might be the very first person to actually submit a real code update. Will look it over in my morning, but I'm seeing about all the files listed that would need updates.

@ammienoot

This comment has been minimized.

Show comment
Hide comment
@ammienoot

ammienoot Oct 9, 2018

Contributor

Very cool, you might be the very first person to actually submit a real code update. Will look it over in my morning, but I'm seeing about all the files listed that would need updates.

I get a lollipop for this - right?

Contributor

ammienoot commented Oct 9, 2018

Very cool, you might be the very first person to actually submit a real code update. Will look it over in my morning, but I'm seeing about all the files listed that would need updates.

I get a lollipop for this - right?

@cogdog

This comment has been minimized.

Show comment
Hide comment
@cogdog

cogdog Oct 9, 2018

Owner

Just combing through the changes in your files it looks to me like you got everything I did in the other SPLOTs, so I'm going to merge it in, then test on my local setup. Not sure if you use this, but I have been a big using Varying Vagrant Vagrants for developing/testing on a local machine rather than the back forth to a server.

I'm so utterly pleased you have gone in and sorted through my code piles, it's something that rarely happens and I know the challenges of following someone else's code lines. You definitely get a lolly.

lollipop-729122_960_720

Owner

cogdog commented Oct 9, 2018

Just combing through the changes in your files it looks to me like you got everything I did in the other SPLOTs, so I'm going to merge it in, then test on my local setup. Not sure if you use this, but I have been a big using Varying Vagrant Vagrants for developing/testing on a local machine rather than the back forth to a server.

I'm so utterly pleased you have gone in and sorted through my code piles, it's something that rarely happens and I know the challenges of following someone else's code lines. You definitely get a lolly.

lollipop-729122_960_720

@cogdog cogdog closed this Oct 9, 2018

@cogdog cogdog reopened this Oct 9, 2018

@cogdog cogdog merged commit 59b7ac6 into cogdog:master Oct 9, 2018

@cogdog

This comment has been minimized.

Show comment
Hide comment
@cogdog

cogdog Oct 9, 2018

Owner

Everything tested okay. I found one variable name I had wrong in original code, and also made a small mod to the template for the page that lists items by license so it only displays ones with counts- e.g. http://splot.ca/box/licensed/

Owner

cogdog commented Oct 9, 2018

Everything tested okay. I found one variable name I had wrong in original code, and also made a small mod to the template for the page that lists items by license so it only displays ones with counts- e.g. http://splot.ca/box/licensed/

@ammienoot

This comment has been minimized.

Show comment
Hide comment
@ammienoot

ammienoot Oct 9, 2018

Contributor
Contributor

ammienoot commented Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment