New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rubinius to Supported Rubies in README. #11

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@brixen

brixen commented Jul 22, 2014

I ran the specs with Rubinius 2.2.10 and all passed as seen below.

Is there any interest in testing on Travis CI? If yes, I can send a PR to enable that as well.

Thanks!

$ bundle exec rspec
Run options: include {:focus=>true, :focused=>true}

All examples were filtered out; ignoring {:focus=>true, :focused=>true}
..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 2.88 seconds (files took 4.01 seconds to load)
842 examples, 0 failures
@yokolet

This comment has been minimized.

Show comment
Hide comment
@yokolet

yokolet Jul 22, 2014

Contributor

Hi Brian, thanks for looking at transit-ruby so soon.

But, we have a policy on pull requests, https://github.com/cognitect/transit-ruby#contributing . Also, nobody have thought of Rubinius while developing the gem (sorry!). Before adding Rubinius to the list, we should discuss about the supported Rubies among transit-ruby devs (Cognitect internally).
For now, I'd suggest you to join transit-format google group, https://groups.google.com/forum/#!forum/transit-format , and post there the topic of Rubinius support.

One more about CI. At this moment, it's not clear what CI will be used for transit-ruby. Once CI server is chosen, I (or other transit-ruby devs) will add a setup script.

Contributor

yokolet commented Jul 22, 2014

Hi Brian, thanks for looking at transit-ruby so soon.

But, we have a policy on pull requests, https://github.com/cognitect/transit-ruby#contributing . Also, nobody have thought of Rubinius while developing the gem (sorry!). Before adding Rubinius to the list, we should discuss about the supported Rubies among transit-ruby devs (Cognitect internally).
For now, I'd suggest you to join transit-format google group, https://groups.google.com/forum/#!forum/transit-format , and post there the topic of Rubinius support.

One more about CI. At this moment, it's not clear what CI will be used for transit-ruby. Once CI server is chosen, I (or other transit-ruby devs) will add a setup script.

@yokolet yokolet closed this Jul 22, 2014

@yokolet

This comment has been minimized.

Show comment
Hide comment
@yokolet

yokolet Dec 8, 2014

Contributor

Hi @brixen
Just let you know. We had the wiki page, https://github.com/cognitect/transit-format/wiki/Community-Implementations , and Rubinius is there. Probably, Cognitect won't support Rubinius officially (won't test transit on Rubinius), but would maintain the list.

Contributor

yokolet commented Dec 8, 2014

Hi @brixen
Just let you know. We had the wiki page, https://github.com/cognitect/transit-format/wiki/Community-Implementations , and Rubinius is there. Probably, Cognitect won't support Rubinius officially (won't test transit on Rubinius), but would maintain the list.

@brixen

This comment has been minimized.

Show comment
Hide comment
@brixen

brixen Dec 9, 2014

@yokolet thank you for letting me know! What would we need to do to get Rubinius officially tested?

brixen commented Dec 9, 2014

@yokolet thank you for letting me know! What would we need to do to get Rubinius officially tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment