New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up time encoding benchmark #12

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jgdavey

jgdavey commented Jul 24, 2014

  • Use bmbm for VM warming
  • Update outdated API calls
Fix up time encoding benchmark
* Use `bmbm` for VM warming
* Update outdated API calls
@dchelimsky

This comment has been minimized.

Show comment
Hide comment
@dchelimsky

dchelimsky Jul 25, 2014

Contributor

Hey @jgdavey, thanks for the contribution but, per https://github.com/cognitect/transit-ruby#contributing we're not accepting any pull requests from anybody outside Cognitect in any of the transit repos. Good changes, though, which I'll gladly adopt and credit you for.

Contributor

dchelimsky commented Jul 25, 2014

Hey @jgdavey, thanks for the contribution but, per https://github.com/cognitect/transit-ruby#contributing we're not accepting any pull requests from anybody outside Cognitect in any of the transit repos. Good changes, though, which I'll gladly adopt and credit you for.

@dchelimsky dchelimsky closed this Jul 25, 2014

@dchelimsky

This comment has been minimized.

Show comment
Hide comment
@dchelimsky

dchelimsky Jul 25, 2014

Contributor

BTW - the other 1/2 of that policy is that we do welcome conversation in https://groups.google.com/forum/#!forum/transit-format. So if you have any ideas about design choices (overall or Ruby-specific), implementation details, etc, please feel free to bring them up in that forum.

Contributor

dchelimsky commented Jul 25, 2014

BTW - the other 1/2 of that policy is that we do welcome conversation in https://groups.google.com/forum/#!forum/transit-format. So if you have any ideas about design choices (overall or Ruby-specific), implementation details, etc, please feel free to bring them up in that forum.

@jgdavey

This comment has been minimized.

Show comment
Hide comment
@jgdavey

jgdavey Jul 25, 2014

Thanks for the clarification. I should have read the contributing section more closely. I'll redirect any subsequent suggestions to the mailing list.

Thanks!

jgdavey commented Jul 25, 2014

Thanks for the clarification. I should have read the contributing section more closely. I'll redirect any subsequent suggestions to the mailing list.

Thanks!

@dchelimsky

This comment has been minimized.

Show comment
Hide comment
@dchelimsky

dchelimsky Jul 25, 2014

Contributor

FYI - I moved the https://github.com/cognitect/transit-ruby#contributing higher up the page - will hopefully help save ppl from doing a bunch of work for naught.

Contributor

dchelimsky commented Jul 25, 2014

FYI - I moved the https://github.com/cognitect/transit-ruby#contributing higher up the page - will hopefully help save ppl from doing a bunch of work for naught.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment