New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.12.0 #175
Conversation
No functionality has changed but interface is different.
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
- Coverage 91.38% 87.66% -3.72%
==========================================
Files 29 19 -10
Lines 2344 1435 -909
==========================================
- Hits 2142 1258 -884
+ Misses 202 177 -25
|
…ta' key is missing
…ecessary to override
Maybe since there have been such substantial changes to the interface, this should be a major, not a minor, version bump? @NilsBarlaug-cognite what do you think? |
This comment has been minimized.
This comment has been minimized.
Also add extra field to APIError
I guess we should normally do that, but since we're in major version zero it depends.
(see https://semver.org) So if we bump to version 1 that would mean we have officially released the first stable version and are not in initial development anymore. I would argue that it doesn't make sense to be major version 1 before the actual underlying API is stable (version 1), since we then can't guarantee that the SDK will not break. In addition, since there are so big changes now it will probably be followed by more changes and bug fixes the coming weeks. We should at least be somewhat stable before we go to major version 1. What do you think @f1cognite? |
…de versioning scheme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️⭐️⭐️⭐️⭐️
* Major rewriting of SDK * Improve documentation * Update docs and make api client limits protected * Change from numbered versioning to stable/experimental * Remove unused code and fix __str__() for CogniteResponse * Remove anything related to versions from documentation * Minor fixes and updates to docstrings * Update api key env var in Jenkinsfile * Update CONTRIBUTING.md * Remove unused print statements and add debug mode * Omit auxiliary directory from coverage report * Increase coverage threshold to 2% * Update documentation and docstrings * Add examples in docs for assets and datapoints * Fix assets test * Add simple examples for events, files, login and time_series * Fix examples in overview * Skip undeterministically failing sequences test * Update main docs * Increase coverage threshold * Fix typo in docs * Update jupyter examples * Clean up docs and fix ordering issue * Move version specification in to each individual client * Make requested changes from F1's review * Update documentation * Remove docstring from top-level __init__.py * Do not retry 401 or POST * Add default timeout of 60s for all requests and let user configure it. * Fix bug in response object __str__() * Return None instead of empty dict where applicable * Remove some outdated kwargs from docstrings * Do not return empty dict as string repr for cognite response when 'data' key is missing * Move to_json() method to CogniteResponse and remove where it is not necessary to override * Use .to_json() in .__str__() of CogniteResponse * Fix failing tests after fixes * Move helpers only used in tests to conftest.py * Update some docstrings and include inherited members in docs * Add more examples * Fix bug in get_datapoints multithreading * Fix bug in example * Remove version parameter in client_factory and make it protected. * Update CONTRIBUTING.md with link to semver.org instead of this homemade versioning scheme * Default to logging at INFO level and do not let user configure this * Fix bug in retry logic causing client to wait after last retry
Client
Restructuring
Documentation
Tests
Data Transfer Service