Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Introduce Typescript to griff-react (#263)" #274

Merged
merged 1 commit into from Mar 26, 2019

Conversation

evancharlton
Copy link
Contributor

This reverts commit 1a94474.

Typescript was fun while it lasted. Revert this until we figure out how
to force nwb to not use src as the entry point.

This reverts commit 1a94474.

Typescript was fun while it lasted. Revert this until we figure out how
to force nwb to not use src as the entry point.
@cognite-cicd
Copy link

[pr-server]
The storybook for this PR is hosted on https://griff-react-pr-274.surge.sh

Copy link
Contributor

@stonecrafter stonecrafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typescript was fun while it lasted

@evancharlton evancharlton merged commit 6e0bc4f into master Mar 26, 2019
@evancharlton evancharlton deleted the fix-typescript-package branch March 26, 2019 14:06
evancharlton pushed a commit that referenced this pull request Mar 27, 2019
This reverts commit 6e0bc4f.

Additionally, this migrates from nwb to rollup so that .js files get
bundled along with the .ts{,x} files during the migration.

Additionally, this removes the demo since Storybook is a *much* better
demo arena.
evancharlton pushed a commit that referenced this pull request Mar 27, 2019
This reverts commit 6e0bc4f.

Additionally, this migrates from nwb to rollup so that .js files get
bundled along with the .ts{,x} files during the migration.

Additionally, this removes the demo since Storybook is a *much* better
demo arena.
evancharlton pushed a commit that referenced this pull request Mar 27, 2019
This reverts commit 6e0bc4f.

Additionally, this migrates from nwb to rollup so that .js files get
bundled along with the .ts{,x} files during the migration.

Additionally, this removes the demo since Storybook is a *much* better
demo arena.
evancharlton pushed a commit that referenced this pull request Mar 27, 2019
This reverts commit 6e0bc4f.

Additionally, this migrates from nwb to rollup so that .js files get
bundled along with the .ts{,x} files during the migration.

Additionally, this removes the demo since Storybook is a *much* better
demo arena.
evancharlton added a commit that referenced this pull request Mar 29, 2019
This reverts commit 6e0bc4f.

Additionally, this migrates from nwb to rollup so that .js files get
bundled along with the .ts{,x} files during the migration.

Additionally, this removes the demo since Storybook is a *much* better
demo arena.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants