Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large reads #2

Merged
merged 5 commits into from May 28, 2019
Merged

Large reads #2

merged 5 commits into from May 28, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@cohosh
@cohosh
Copy link
Owner

@cohosh cohosh commented May 28, 2019

No description provided.

cohosh added 4 commits May 28, 2019
@cohosh
Guard against large reads
ce3101d 
This is a fix for #26348
@cohosh
Implement limitedRead function for client side
1d76d3c 
MaxBytesReader is only documented for server side reads, so we're using
a local limitedRead function instead that uses an io.LimitedReader.

Declared limits in a commented constant
@cohosh
Added tests to check large read guards
0842dad
@cohosh
Simplified limitedReader by reading one extra byte
254e6b9
@cohosh
Keyed composite literal to avoid go vet warning
cd650fa
@cohosh cohosh merged commit cd650fa into master May 28, 2019
2 checks passed
@cohosh cohosh deleted the large_reads branch Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment