Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified broker /debug page to display counts only #6

Closed
wants to merge 0 commits into from
Closed

Conversation

Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@cohosh
Copy link
Owner

@cohosh cohosh commented Aug 23, 2019

The broker /debug page was displaying proxy IDs and roundtrip times. As
serna pointed out in bug #31460, the proxy IDs can be used to launch a
denial of service attack. As the metrics team pointed out on #21315, the
round trip time average can be potentially sensitive.

This change displays only proxy counts and uses ID lengths to
distinguish between standalone proxy-go instances and browser-based
snowflake proxies.

@cohosh cohosh closed this Aug 28, 2019
@cohosh cohosh deleted the fix31460 branch Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment