New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove embedded files, put config in envars and investigators in s3 #12

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@hkparker
Collaborator

hkparker commented Nov 1, 2018

This PR accomplishes the following:

  • Remove embedded investigator files

This is important for usability. Previously investigator public keys were embedded into the dexter binaries, which made issuing and revoking investigators difficult as a re-deploy was required. Now investigators are stored in S3. Closes #2.

  • Move all configuration to environment variables

This lets me remove embedded files altogether, simplifying the build process and opening the door to distributing binaries (not a goal at this time, but possible now). Removes the need for configuration versions, closes #3.

  • Move consensus requirements to task definitions

This makes task development slightly easier, as now there truly is only one file to edit. Part of removing embedded files, and closes #8.

  • Increases test coverage

I'll be adding tests related to the parts of code I change as I go, so this works toward closing #1.

@hkparker hkparker force-pushed the hayden-move-investigators-to-s3 branch 6 times, most recently from 9d2e01b to 29c5fa2 Nov 1, 2018

@hkparker hkparker changed the title from [WIP] remove embedded files, put config in envars and investigators in s3 to remove embedded files, put config in envars and investigators in s3 Nov 5, 2018

@hkparker hkparker force-pushed the hayden-move-investigators-to-s3 branch from 29c5fa2 to ff91a1b Nov 5, 2018

@hkparker hkparker force-pushed the hayden-move-investigators-to-s3 branch from ff91a1b to e8c6fb0 Nov 6, 2018

if err != nil {
color.HiRed("error revoking investigator: " + err.Error())
} else {
color.HiGreen("Investigator Revoked!")

This comment has been minimized.

@zblach

zblach Nov 6, 2018

Inconsistency in messaging capitalization

path := "investigators/" + name + ".json"
err := helpers.DeleteS3File(path)
if err != nil {
color.HiRed("error revoking investigator: " + err.Error())

This comment has been minimized.

@zblach

zblach Nov 6, 2018

Consider processing or propagating this error, instead of just continuing along.

@zblach

zblach approved these changes Nov 6, 2018

@hkparker hkparker merged commit 7bbbde7 into master Nov 8, 2018

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@hkparker hkparker deleted the hayden-move-investigators-to-s3 branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment