Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alb target group attachments #331

Merged
merged 1 commit into from Jul 15, 2019

Conversation

2 participants
@jtokoph
Copy link
Contributor

commented Jul 1, 2019

This is a work in progress for adding support for ALB listeners with routing rules.

Changes

  • Add resource for target group attachments
  • Disable tag and name validation for listener rules
  • Split validation for lambda and instance target groups

TODO

  • Confirm this is the correct way to implement
  • Add specs

@jtokoph jtokoph changed the title [WIP] Add support for alb target group attachments [HELP NEEDED] Add support for alb target group attachments Jul 3, 2019

@jtokoph jtokoph changed the title [HELP NEEDED] Add support for alb target group attachments Add support for alb target group attachments Jul 12, 2019

@jtokoph jtokoph force-pushed the jtokoph:tokoph/lambda-target-groups branch from 766790a to 5d83027 Jul 12, 2019

@jtokoph jtokoph force-pushed the jtokoph:tokoph/lambda-target-groups branch from 5d83027 to e5c8593 Jul 12, 2019

@kmur911 kmur911 merged commit 379446e into coinbase:master Jul 15, 2019

3 checks passed

Heimdall Review Status Review progress 1/1
Details
ci/circleci: rubocop Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.