Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Allow Resource to have urlRoots without a trailing slash #121

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@WilhelmWillie
Copy link
Contributor

commented Aug 9, 2019

Fixes #81

Motivation

See issue: #81

Solution

Simple conditionals!


Always wanted to submit an open source PR, saw issue #81, seemed like a good start :) Appreciate any feedback

Wilhelm Willie
@@ -37,13 +37,26 @@ describe('Resource', () => {
);
});
it('should render url property', () => {
CoolerArticleResource.urlRoot = 'http://test.com/article-cooler';

This comment has been minimized.

Copy link
@ntucker

ntucker Aug 9, 2019

Member

is this supposed to be here?

This comment has been minimized.

Copy link
@WilhelmWillie

WilhelmWillie Aug 9, 2019

Author Contributor

whoops nope

Wilhelm Willie

@ntucker ntucker merged commit 9c20f78 into coinbase:master Aug 9, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: salus Your tests passed on CircleCI!
Details

@WilhelmWillie WilhelmWillie deleted the WilhelmWillie:willie/check-trailing-slash branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.