chore: strengthen spec-review/draft with API safety checks#171
Merged
Conversation
- Add step 5 to spec-review: check for invalid input tests on new public API options, async in-flight guards, doc example correctness, and explicit behavior preservation criteria - Add matching items to spec-draft quality checklist - Remove remaining vitest-attachments PNG Learned from #169 CodeRabbit review: pollingIntervalMs lacked input validation and in-flight guard, isDomainEvent examples were redundant. These should have been caught at spec stage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 Walkthroughウォークスルー
変更点
推定コードレビュー工数🎯 1 (Trivial) | ⏱️ ~3分 関連の可能性があるPR
ポエム
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Retrospective from #169 (event classification PR): CodeRabbit caught
pollingIntervalMslacking input validation and in-flight guard, plus redundantisDomainEventexamples. These should have been caught at spec stage — spec-review now checks for these patterns.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート
注記: このリリースに含まれるのは内部プロセスドキュメントの改善のみであり、ユーザー向けの機能変更はありません。