fix(durably-react): add isCancelled to client-mode useJob#22
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughIntroduces Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coji
force-pushed
the
fix/add-iscancelled-to-client-usejob
branch
from
a68ff91 to
f53da80
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@openspec/changes/add-human-in-the-loop/specs/react/spec.md`:
- Around line 9-10: The mode label for the client variant is incorrect: change
the text so that "`useHumanWaits({ api })` in `@coji/durably-react/client`" is
labeled "(client mode)" instead of "(server mode)". Locate the spec entry
referencing the two variants (`useHumanWaits()` in `@coji/durably-react` and
`useHumanWaits({ api })` in `@coji/durably-react/client`) and update only the
parenthetical mode label for the `/client` entry to read "client mode" to match
the package path and scenario heading.
🧹 Nitpick comments (1)
CLAUDE.md (1)
83-85: Consider language consistency in documentation.The new Skills section uses Japanese text while the rest of CLAUDE.md is in English. This creates a language inconsistency that may affect readability for international contributors.
Suggested English translation
## Skills -- **release-check** - API変更・仕様追加時のパッケージ整合性チェック（`.claude/skills/release-check/`） +- **release-check** - Package consistency checks for API changes and spec additions (`.claude/skills/release-check/`)
Add missing isCancelled state boolean to UseJobClientResult interface and return value. This makes client-mode useJob consistent with browser-mode useJob which already included isCancelled. - Add isCancelled: boolean to UseJobClientResult<TInput, TOutput> - Add isCancelled: effectiveStatus === 'cancelled' to return object - Update openspec/specs/react/spec.md to document the requirement Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
coji
force-pushed
the
fix/add-iscancelled-to-client-usejob
branch
from
f53da80 to
ce2de78
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useJobにisCancelledステータスブーリアンを追加（Browser-mode との整合性を確保）release-checkスキルを新規作成（API変更時のパッケージ整合性チェック用）Changes
Implementation
packages/durably-react/src/client/use-job.ts-isCancelled追加Documentation
packages/durably-react/docs/llms.mddocs/spec-react.mdwebsite/api/durably-react/browser.mdwebsite/api/durably-react/client.mdpackages/durably-react/README.mdTooling
.claude/skills/release-check/SKILL.md- 新規作成CLAUDE.md- Skills セクション追加Version
packages/durably→ 0.8.1packages/durably-react→ 0.8.1Test plan
pnpm validate全パスisCancelledが利用可能🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
isCancelledboolean flag to theuseJobhook for tracking cancelled job states across all modes.isPending,isFailed) to client-mode API for better consistency with browser-mode.Documentation
✏️ Tip: You can customize this high-level summary in your review settings.