chore: release v0.12.0#96
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR renames the public retry API to Changes
Sequence DiagramsequenceDiagram
participant Client as Client
participant Server as Server
participant JobRegistry as JobRegistry
participant RunFactory as RunFactory
participant Storage as Storage
Client->>Server: POST /retrigger { runId }
Server->>JobRegistry: validate job for runId
alt job not registered
JobRegistry-->>Server: throw "Unknown job"
Server-->>Client: Error
else job registered
JobRegistry-->>Server: OK
Server->>RunFactory: create new Run from previous run
RunFactory->>Storage: save new Run
RunFactory->>Storage: request delete of previous run steps (cleanupSteps)
Storage-->>RunFactory: ack
RunFactory-->>Server: new runId
Server-->>Client: { success: true, runId }
Server->>Server: emit `run:trigger` for new run
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
CHANGELOG.md (1)
21-21: Consider clarifying event replacement behavior.The documentation states
run:retryevent is removed andretrigger()now emitsrun:trigger, but it might be worth noting explicitly that the emitted event represents the new run being triggered (sinceretrigger()creates a fresh run with a new ID), not a retry of the original run. This distinction helps users understand why the event model changed.📝 Suggested clarification
-- **Remove `run:retry` event**: `retrigger()` now emits `run:trigger` instead. `RunRetryEvent` type removed (`#91`) +- **Remove `run:retry` event**: `retrigger()` now emits `run:trigger` for the new run it creates (since it generates a fresh run ID). `RunRetryEvent` type removed (`#91`)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CHANGELOG.md` at line 21, Update the CHANGELOG entry to explicitly state that the old run:retry event was removed because retrigger() now creates a fresh run with a new ID and emits run:trigger for that new run (not a retry of the original); mention that RunRetryEvent type was removed and that consumers should listen for run:trigger and use the new run ID from the emitted payload to track the retriggered execution.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@CHANGELOG.md`:
- Line 21: Update the CHANGELOG entry to explicitly state that the old run:retry
event was removed because retrigger() now creates a fresh run with a new ID and
emits run:trigger for that new run (not a retry of the original); mention that
RunRetryEvent type was removed and that consumers should listen for run:trigger
and use the new run ID from the emitted payload to track the retriggered
execution.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 74e216f8-aec8-42b5-bc7e-3903147ea68a
📒 Files selected for processing (3)
CHANGELOG.mdpackages/durably-react/package.jsonpackages/durably/package.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
coji
force-pushed
the
chore/release-v0.12.0
branch
from
4242b4b to
8480222
Compare
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release v0.12.0 — version bump and changelog.
Breaking Changes
retry()→retrigger()(new run ID, returnsPromise<Run>)run:retryevent removed,RunRetryEventtype removedcleanupSteps: trueby default (step data auto-deleted on terminal state)POST /retry→POST /retriggerAdded
cleanupStepsoptionjobRegistrycheck inretrigger()getRunOrThrow(),executeAction()helpersChanges since v0.11.0
🤖 Generated with Claude Code
Summary by CodeRabbit
Breaking Changes
retry()renamed toretrigger()and now returns the new run ID instead of void.run:retryevent replaced byrun:trigger.retrigger()now throws "Unknown job" immediately if the job is unregistered.New Features
cleanupSteps: false.deleteSteps()for manual step cleanup.retriggernow returns the new run ID.