Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

rotation problems #44

Closed
ttsalo opened this Issue · 2 comments

3 participants

@ttsalo

I'm currently designing a machine part using ImplicitCAD's Haskell interface, from today's git sources. I ran into an issue when I wanted to create a bolt pattern for a motor by rotation. The public interface was missing "rotate" and "rotate3". So I edited the Implicit.hs file and added those.

However, after this I noticed that "rotate3 (0, 0, 0)" is not an identity operation, "rotate3 (pi/2, 0, 0)" is. That seems somewhat odd... is this the intended behaviour?

@colah
Owner

... I'm going to have to say that that is a bug. I'll look at it. Thanks!

@bgamari bgamari referenced this issue from a commit in bgamari/ImplicitCAD
@bgamari bgamari Rotate3: Fix flipped sin/cos
Previously `rotate3 (pi/2) 0 0` was an identity while `rotate3 0 0 0`
resulted in a rotation as pointed out in Issue #44.
3761302
@bgamari

I believe this should be fixed now.

@colah colah closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.