rotation problems #44

Closed
ttsalo opened this Issue Apr 6, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@ttsalo

ttsalo commented Apr 6, 2012

I'm currently designing a machine part using ImplicitCAD's Haskell interface, from today's git sources. I ran into an issue when I wanted to create a bolt pattern for a motor by rotation. The public interface was missing "rotate" and "rotate3". So I edited the Implicit.hs file and added those.

However, after this I noticed that "rotate3 (0, 0, 0)" is not an identity operation, "rotate3 (pi/2, 0, 0)" is. That seems somewhat odd... is this the intended behaviour?

@colah

This comment has been minimized.

Show comment Hide comment
@colah

colah Apr 8, 2012

Owner

... I'm going to have to say that that is a bug. I'll look at it. Thanks!

Owner

colah commented Apr 8, 2012

... I'm going to have to say that that is a bug. I'll look at it. Thanks!

bgamari added a commit to bgamari/ImplicitCAD that referenced this issue Nov 18, 2012

Rotate3: Fix flipped sin/cos
Previously `rotate3 (pi/2) 0 0` was an identity while `rotate3 0 0 0`
resulted in a rotation as pointed out in Issue #44.
@bgamari

This comment has been minimized.

Show comment Hide comment
@bgamari

bgamari Nov 24, 2012

Contributor

I believe this should be fixed now.

Contributor

bgamari commented Nov 24, 2012

I believe this should be fixed now.

@colah colah closed this Dec 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment