Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

scad rotate fixes #35

Merged
merged 1 commit into from Mar 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

tolomea commented Mar 4, 2012

#31 and #34

Owner

colah commented Mar 5, 2012

Merging, though I don't like using degrees. I think we should probably rewrite this so that users can specify how they want to describe angles at some point.

@colah colah added a commit that referenced this pull request Mar 5, 2012

@colah colah Merge pull request #35 from tolomea/rotate
scad rotate fixes
1acb4b3

@colah colah merged commit 1acb4b3 into colah:master Mar 5, 2012

Contributor

tolomea commented Mar 5, 2012

I think we need a clear decision on degrees vs radians internally and to
convert to and from that as close to the user as possible. I know from
previous projects that having different bits of code using different units
is a bad idea. My preference would be whatever haskells trig functions
expect
With regard to what the user inputs, degrees generally do a better job than
radians. There are 2 main reasons for this:
1: They are much more widely known, so using them makes the tool more
approachable and that in turn drives adoption.
2: They have nice concise rational representations for many of the most
significant values like a whole circle, 1/2, 1/3, 1/4, 1/5, 1/6, 1/8, 1/10,
1/12, 1/16 of a circle.
One alternative that would be interesting is fractions of a circle, so n
where radians = tau/n.

G

On Mon, Mar 5, 2012 at 8:22 PM, Christopher Olah <
reply@reply.github.com

wrote:

Merging, though I don't like using degrees. I think we should probably
rewrite this so that users can specify how they want to describe angles at
some point.


Reply to this email directly or view it on GitHub:
#35 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment