Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

extopenscad: Add real command line argument handling #90

Merged
merged 1 commit into from Dec 22, 2012

Conversation

Projects
None yet
2 participants
Contributor

bgamari commented Dec 19, 2012

No description provided.

@bgamari bgamari referenced this pull request Dec 19, 2012

Closed

extopenscad --help #41

Owner

colah commented Dec 19, 2012

@bgamari : Thank you for writing this. It looks like great code, but there seem to be issues with optparse-applicative under GHC 7.0.4. Since many of our users will be trying to build ImplicitCAD under older GHC versions (many linux distros ship GHC 7.0.4), I'm concerned about this. The issue seems to be rather minor, declaring use of the TypeSynonymInstances extension. Feel like looking into it (ie. contacting the author)?

Contributor

bgamari commented Dec 19, 2012

Sure. I'll ask him about it.

Owner

colah commented Dec 19, 2012

Awesome, thanks!!

Owner

colah commented Dec 20, 2012

So, you mentioned on IRC that the author had fixed it and would release soon. Can we confirm that soon is within the next week or two? I'm happy to merge this, but if we want to do a release soon we should confirm that the code we are releasing will work for everyone. :)

Contributor

bgamari commented Dec 22, 2012

I believe it happened today. Should be safe to merge.

@colah colah added a commit that referenced this pull request Dec 22, 2012

@colah colah Merge pull request #90 from bgamari/argument-parsing
extopenscad: Add real command line argument handling
253d715

@colah colah merged commit 253d715 into colah:master Dec 22, 2012

Owner

colah commented Dec 22, 2012

Great! Thanks for handling this, @bgamari!

@bgamari bgamari deleted the bgamari:argument-parsing branch Dec 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment