Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for remove background #62

Merged
merged 1 commit into from Oct 7, 2023

Conversation

funbunch
Copy link
Contributor

@funbunch funbunch commented Oct 6, 2023

Description

Adding test for removing background.

Issue Ticket Number

This is in reference to this issue here: #64

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudinary-util ❌ Failed (Inspect) Oct 6, 2023 6:45pm

@colbyfayock
Copy link
Owner

look great, thanks @funbunch

@colbyfayock colbyfayock merged commit 971e0c9 into colbyfayock:main Oct 7, 2023
3 of 4 checks passed
@colbyfayock
Copy link
Owner

@all-contributors please add @funbunch for test

@allcontributors
Copy link
Contributor

@colbyfayock

I've put up a pull request to add @funbunch! 🎉

@colbyfayock
Copy link
Owner

@funbunch congrats on the merged PR! since it's officially October, you've always qualified for Hacktoberfest swag! please email hacktoberfest@cloudinary.com with your github username and a link to your contribution where I'll follow up to request more information for getting you your swag

https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks

colbyfayock pushed a commit that referenced this pull request Oct 7, 2023
Adds @funbunch as a contributor for test.

This was requested by colbyfayock [in this
comment](#62 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@github-actions
Copy link

🎉 This PR is included in version @cloudinary-util/url-loader-v3.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants