Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generative Replace (#68) #80

Merged
merged 1 commit into from Oct 31, 2023

Conversation

michaeljolley
Copy link
Contributor

Description

Added Generative Replace. Can be utilized in one of two ways:

{
  replace: {
    from: "apple",
    to: "orange",
  }
}

or

{
  replace: [ "apple", "orange" ]
}

Both options provide the preserve-geometry boolean parameter via the preserveGeometry property or as third option in the array.

This also includes 5 new tests for the plugin (and various ways of using it.)

Issue Ticket Number

Fixes #68

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudinary-util ❌ Failed (Inspect) Oct 31, 2023 6:41pm

@colbyfayock
Copy link
Owner

this looks spot on @michaeljolley! thanks for putting this together, i'm excited to get it into the downstream projects

@colbyfayock colbyfayock merged commit 0c5e96d into colbyfayock:main Oct 31, 2023
3 of 4 checks passed
@colbyfayock
Copy link
Owner

@all-contributors please add @michaeljolley for code

Copy link
Contributor

@colbyfayock

I've put up a pull request to add @michaeljolley! 🎉

@colbyfayock
Copy link
Owner

@michaeljolley congrats on the merged PR! since it's officially October, you've always qualified for Hacktoberfest swag! please email hacktoberfest@cloudinary.com with your github username and a link to your contribution where I'll follow up to request more information for getting you your swag

https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks

github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
Copy link

🎉 This PR is included in version @cloudinary-util/url-loader-v3.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

colbyfayock pushed a commit that referenced this pull request Oct 31, 2023
Adds @michaeljolley as a contributor for code.

This was requested by colbyfayock [in this
comment](#80 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@michaeljolley michaeljolley deleted the generative-replace branch November 1, 2023 01:40
@colbyfayock
Copy link
Owner

#80 (comment)

hey @michaeljolley, haven't seen you reach out about the Hacktoberfest swag. please do as the cutoff to claim swag will be end of day this Friday 11/17. thanks

@michaeljolley
Copy link
Contributor Author

Oh dude! I didn't read the comment. I was wondering if you/Cloudinary would reach out. On it now. Thanks @colbyfayock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add new plugin for Generative Replace
2 participants