Add dynamic logos based on color scheme in README (close #38) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-cloudinary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I'm not sure why these are triggering a failure here specifically it may be an env variable issue. i tested locally to make sure. merging in thanks for the contribution here as well. the hacktoberfest swag is 1 per person, so see my message on the other repository for how to claim |
|
@all-contributors please add @3t8 for doc |
|
I've put up a pull request to add @3t8! 🎉 |
colbyfayock
pushed a commit
that referenced
this pull request
Oct 19, 2022
Adds @3t8 as a contributor for doc. This was requested by colbyfayock [in this comment](#39 (comment)) [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
matiasfha
pushed a commit
to matiasfha/netlify-plugin-cloudinary
that referenced
this pull request
Sep 23, 2023
…ary-community#38) (cloudinary-community#39) # Description Logo images in README change dynamically, adapting to the user's theme ## Issue Ticket Number <!-- Specifiy which issue this fixes by referencing the issue number (`cloudinary-community#11`) or issue URL. --> <!-- Example: Fixes cloudinary-community#1 --> Fixes cloudinary-community#38 ## Type of change <!-- Please select all options that are applicable. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # Checklist <!-- These must all be followed and checked. --> - [x] I have followed the contributing guidelines of this project as mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] I have created an [issue](https://github.com/colbyfayock/netlify-plugin-cloudinary/issues) ticket for this PR - [x] I have checked to ensure there aren't other open [Pull Requests](https://github.com/colbyfayock/netlify-plugin-cloudinary/pulls) for the same update/change? - [x] I have performed a self-review of my own code - [x] I have run tests locally to ensure they all pass - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes needed to the documentation
matiasfha
pushed a commit
to matiasfha/netlify-plugin-cloudinary
that referenced
this pull request
Sep 23, 2023
Adds @3t8 as a contributor for doc. This was requested by colbyfayock [in this comment](cloudinary-community#39 (comment)) [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logo images in README change dynamically, adapting to the user's theme
Issue Ticket Number
Fixes #38
Type of change
Checklist