Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundler integeration, test updates, and other minor changes #3

Merged
merged 5 commits into from Jan 2, 2012
Merged

Bundler integeration, test updates, and other minor changes #3

merged 5 commits into from Jan 2, 2012

Conversation

pcting
Copy link
Contributor

@pcting pcting commented May 31, 2011

  1. Added support for bundler:
    $ git clone ... && cd ./log4r_checkout/
    $ bundle update
    $ bundle exec rake test
    $ bundle exec rake install
    $ bundle exec rake build
  2. Migrated to a gemspec file
  3. I was wrapping my custom exceptions without the backtrace set and found out i was getting errors so i made this patch

@pcting
Copy link
Contributor Author

pcting commented Jun 9, 2011

so i added a massive change. hopefully it's something you're interested in. so i updated the code to work with bundler. To setup your environment:
$ git clone ... && cd ./log4r_checkout/
$ bundle update
$ bundle exec rake test
$ bundle exec rake install
$ bundle exec rake build

let me know what you think

@pcting
Copy link
Contributor Author

pcting commented Jun 9, 2011

oh ya... so all the tests run, but not all of them pass as the tests are quite out dated. I had to change all the "assert_no_exception" methods to "assert_nothing_raised" and "assert_exception" to "assert_raise" along with other tweaks to get the tests to run

colbygk pushed a commit that referenced this pull request Jan 2, 2012
Bundler integeration, test updates, and other minor changes
@colbygk colbygk merged commit fa5bdcc into colbygk:master Jan 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants