Explicitly fix script permissions after copying #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two reasons for this change: 1. The permissions on these files may get changed if the source code is packaged into a format that doesn't support storing the permissions, and the current implementation relies on copying the files with the permissions intact. 2. Some of these scripts are templates, which can't be executed as-is. Removing the executable permissions from the file makes this more clear.
Since the desired permissions are pretty obvious, it's easier to just set the permissions instead of trying to add executable permissions to the existing file. Evidently os.chmod sets the permissions explicitly and isn't additive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two reasons for this change:
This issue was discovered when RPM packaging automation attempted to detect the shell requirements for this package and tripped over the template syntax in some of the templates: https://bugzilla.redhat.com/1908156