Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use preferred encoding to decode environment variables #95

Merged
merged 1 commit into from
Aug 5, 2018

Conversation

dirk-thomas
Copy link
Member

Fixes #92.

@dirk-thomas dirk-thomas added enhancement New feature or request review Waiting for review (Kanban column) labels Aug 3, 2018
@dirk-thomas dirk-thomas self-assigned this Aug 3, 2018
@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #95 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   78.03%   78.08%   +0.05%     
==========================================
  Files          50       50              
  Lines        2777     2784       +7     
  Branches      463      463              
==========================================
+ Hits         2167     2174       +7     
  Misses        588      588              
  Partials       22       22
Impacted Files Coverage Δ
colcon_core/shell/__init__.py 99.41% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdafc7e...cd0115f. Read the comment docs.

Copy link
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me.
Didnt test it locally but I assume it proved to fix the original locale issue

@dirk-thomas dirk-thomas added this to the 0.3.7 milestone Aug 5, 2018
@dirk-thomas dirk-thomas merged commit 018e2b7 into master Aug 5, 2018
@dirk-thomas dirk-thomas deleted the use_encoding_for_env branch August 5, 2018 00:57
@dirk-thomas dirk-thomas removed the review Waiting for review (Kanban column) label Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants