Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix comment and test #5

Merged
merged 2 commits into from

2 participants

@Jille

No description provided.

@colder colder merged commit b725d14 into from
@colder
Owner

Thanks for these!

Btw, the test you contributed (007) doesn't actually use any WeakRef :)

@Jille

Whoops. I changed 'new WeakRef' into 'array' to make sure the problem was in WeakRef instead of just PHP itself. I filed a new pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 13, 2012
  1. @Jille

    Fix comment added in 281ad6d

    Jille authored
  2. @Jille

    Fix typo in tests expect

    Jille authored
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +1 −1  tests/weakref_008.phpt
  2. +1 −1  wr_weakref.c
View
2  tests/weakref_008.phpt
@@ -11,6 +11,6 @@ unset($ref);
echo "done...\n";
?>
--EXPECTF--
-set...
+get...
unset...
done...
View
2  wr_weakref.c
@@ -56,7 +56,7 @@ static int wr_weakref_ref_release(wr_weakref_object *intern TSRMLS_DC) /* {{{ */
if (intern->valid && (intern->acquired > 0)) {
intern->acquired--;
if (intern->acquired == 0) {
- // We need to register that ref so that the object doesn't get collected
+ // We need to unregister that ref so that the object can get collected
Z_OBJ_HANDLER_P(intern->ref, del_ref)(intern->ref TSRMLS_CC);
}
return SUCCESS;
Something went wrong with that request. Please try again.