Fix duplicate symbol errors on LLVM (MacOS) #8

Merged
merged 1 commit into from Nov 5, 2012

Projects

None yet

2 participants

@jasonstubbs

With the variable definitions being in the header files and included from both wr_weakref/wr_weakmap and php_weakref, there are several duplicate symbol errors that aren't automatically resolved with llvm:

duplicate symbol _wr_ce_WeakRef in:
.libs/php_weakref.o
.libs/wr_weakref.o
duplicate symbol _wr_handler_WeakRef in:
.libs/php_weakref.o
.libs/wr_weakref.o
duplicate symbol _weakref_globals in:
.libs/php_weakref.o
.libs/wr_weakref.o
duplicate symbol _wr_ce_WeakMap in:
.libs/php_weakref.o
.libs/wr_weakmap.o
duplicate symbol _wr_handler_WeakMap in:
.libs/php_weakref.o
.libs/wr_weakmap.o
duplicate symbol _wr_handler_WeakRef in:
.libs/php_weakref.o
.libs/wr_weakmap.o
duplicate symbol _wr_ce_WeakRef in:
.libs/php_weakref.o
.libs/wr_weakmap.o
duplicate symbol _weakref_globals in:
.libs/php_weakref.o
.libs/wr_weakmap.o

@colder colder merged commit 23ae021 into colder:master Nov 5, 2012
@colder
Owner
colder commented Nov 5, 2012

Thanks for this!

I had no idea it could cause troubles.

@reeze reeze referenced this pull request in krakjoe/pthreads Nov 9, 2012
Merged

Fix issue #14 os x build failed #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment