Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test cert validity to 2049 #92

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@bmwiedemann
Copy link
Contributor

bmwiedemann commented Oct 8, 2019

Extend test cert validity to 2049
to make tests pass after 2028

Background:
As part of my work on reproducible builds for openSUSE, I check
that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect
some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.

Note: I tested that i586 builds still pass tests on 2037-12-01
so this change introduces no year2038 problem.

to make tests pass after 2028

Background:
As part of my work on reproducible builds for openSUSE, I check
that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect
some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.

Note: I tested that i586 builds still pass tests on 2037-12-01
so this change introduces no year2038 problem.
@cole cole merged commit 5a3cdfb into cole:master Oct 14, 2019
18 of 21 checks passed
18 of 21 checks passed
ci/circleci: py38 Your tests failed on CircleCI
Details
cole.aiosmtplib Build #20191008.2 failed
Details
cole.aiosmtplib (Test Python38) Test Python38 failed
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py35 Your tests passed on CircleCI!
Details
ci/circleci: py352 Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details
ci/circleci: py37 Your tests passed on CircleCI!
Details
ci/circleci: pypy35 Your tests passed on CircleCI!
Details
ci/circleci: pypy36 Your tests passed on CircleCI!
Details
cole.aiosmtplib (Docs) Docs succeeded
Details
cole.aiosmtplib (Lint) Lint succeeded
Details
cole.aiosmtplib (Test PyPy35) Test PyPy35 succeeded
Details
cole.aiosmtplib (Test PyPy36) Test PyPy36 succeeded
Details
cole.aiosmtplib (Test Python35) Test Python35 succeeded
Details
cole.aiosmtplib (Test Python352) Test Python352 succeeded
Details
cole.aiosmtplib (Test Python36) Test Python36 succeeded
Details
cole.aiosmtplib (Test Python37) Test Python37 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - docs/requirements.txt (cole) No manifest changes detected
@cole

This comment has been minimized.

Copy link
Owner

cole commented Oct 14, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.