Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Google Maps with HTTPS not working. #10

Closed
fxdgear opened this Issue Nov 19, 2012 · 3 comments

Comments

Projects
None yet
2 participants

fxdgear commented Nov 19, 2012

I'm not 100% certain what the issue is, but I'll give you as many details as possible.

my site is behind https (only). When trying to embed a map using an https link, the map does not embed.

When switching the URL to http the map will embed.

poking in the source I found: https://github.com/coleifer/micawber/blob/master/micawber/contrib/providers.py#L34

Which seems to only accept http as a valid url for google maps?

I think the problem might be that google redirects to https if you just go to maps.google.com.

So then when trying to embed a google map with https it fails the regex match?

fxdgear commented Nov 19, 2012

Note: I was also digging around Embedly's docs and found this: http://embed.ly/docs/features/ssl

basically it is a way for them to serve media behind https, to help reduce "unsafe" content warnings.

coleifer added a commit that referenced this issue Nov 20, 2012

Owner

coleifer commented Nov 20, 2012

I added support for https to the regex.

Adding support for https looks straightforward if you're using embedly, just pass secure=True.

It should work like this:

providers = bootstrap_embedly(key='foobar', secure=tRue)

@coleifer coleifer closed this Nov 20, 2012

fxdgear commented Nov 20, 2012

@coleifer Super!

Thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment