pwiz columns invalid names

[vinczente]

in mysql fields can be named:
"source id"
"marketing/position"
in this case pwiz creates python model attributes of the same name.
Related issue: #184

[coleifer]

Hmmm....

[coleifer]

Hmmm....

[coleifer]

Can you explain this in a bit more detail? What exactly is the nature of this bug?

[coleifer]

Can you explain this in a bit more detail? What exactly is the nature of this bug?

[vinczente]

This is a example of generated code from pwiz

class Flag(BaseModel):
description = TextField(null=True)
flag id = CharField(null=True)
name = CharField(null=True)

python will syntax error:

flag id = CharField(null=True)
      ^

SyntaxError: invalid syntax

[vinczente]

This is a example of generated code from pwiz

class Flag(BaseModel):
description = TextField(null=True)
flag id = CharField(null=True)
name = CharField(null=True)

python will syntax error:

flag id = CharField(null=True)
      ^

SyntaxError: invalid syntax

[vinczente]

Solution could be to escape the fields name and use a db_column property

flag_id = CharField(db_column='flag id', null=True)

[vinczente]

Solution could be to escape the fields name and use a db_column property

flag_id = CharField(db_column='flag id', null=True)