Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add assert_matches as unstable feature #81

Merged
merged 2 commits into from Aug 23, 2021

Conversation

tommilligan
Copy link
Collaborator

@tommilligan tommilligan commented Aug 14, 2021

Closes #80

Inlines the existing top level implementation of stdlib's assert_matches, and links it into our existing display framework. The results look... okay. Patterns don't come with nice multiline displaying, so we're mostly diffing a value against a pattern - but just getting them displayed in red/green and on separate lines is still nice.

image

@gilescope this was your suggestion, so will leave open for a bit if you have any further thoughts?

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2021

Codecov Report

Merging #81 (cf21269) into main (55f9b7a) will not change coverage.
The diff coverage is n/a.

Current head cf21269 differs from pull request most recent head d084599. Consider uploading reports for the commit d084599 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files           4        4           
  Lines         197      197           
=======================================
  Hits          191      191           
  Misses          6        6           
Impacted Files Coverage Δ
pretty_assertions/src/lib.rs 100.00% <ø> (ø)
pretty_assertions/tests/macros.rs 98.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f9b7a...d084599. Read the comment docs.

@gilescope
Copy link

gilescope commented Aug 15, 2021

That's smashing! You've made my day. Yes closes the issue.

@tommilligan tommilligan merged commit 9ef3e0d into colin-kiegel:main Aug 23, 2021
7 checks passed
@tommilligan tommilligan deleted the assert-matches branch Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants