Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Made change to /demos/index.html #24

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

MylesBorins commented Aug 7, 2012

Moved

  • elements into the links to make entire area clickable

  • @colinbdclark colinbdclark added a commit that referenced this pull request Aug 12, 2012

    @colinbdclark colinbdclark Merge branch 'button-list'
    * button-list:
      Fixes gh-24. Styles button lists in demos to be fully clickable. This solution uses CSS to style the anchors correctly, rather than using invalid markup.
    9acac59
    Owner

    colinbdclark commented Aug 12, 2012

    Myles,

    Thanks very much for the pull request. Your solution solved the problem, but it introduced invalid HTML markup. You can't nest anchors directly within a

      or
        tag; they have to be within the
      1. .

        Instead, I resolved this issue by improving the CSS for the demos. Thanks for bringing the issue up and giving me some incentive to fix it!

    @colinbdclark colinbdclark added a commit that referenced this pull request Sep 3, 2012

    @colinbdclark colinbdclark Merge branch 'master' into synth-groups
    * master:
      Adds support to Scheduler for converting between units (currently seconds and beats).
      Temporarily adds flock.component() prior to a move to Fluid Infusion.
      Adds support for removing individual Scheduler listeners.
      Resolves gh-25 with more unit tests for Myles' fix to scheduler.clearRepeat/clearAll().
      Refactored code for clearing events bound to interval workers.  Wrote unit test for async.repeat()... these tests are failing showing that more work is needed
      Updated Scheduler to release events on .clearRepeat()
      Renames conductor to scheduler; adds new scheduling functions.
      Fixes gh-24. Styles button lists in demos to be fully clickable. This solution uses CSS to style the anchors correctly, rather than using invalid markup.
      Updates to latest version of sheep.js with support for min/max.
    0809f0d

    @colinbdclark colinbdclark added a commit that referenced this pull request Sep 8, 2012

    @colinbdclark colinbdclark Merged master and updated impulse to standard ugen idioms.
    Merge branch 'master' into impulse
    
    * master: (70 commits)
      Fixes bugs in beat scheduler.
      Improves factoring of time converters in the Scheduler.
      Increases tolerance for mistimed events in the Scheduler's unit tests. This is due to the fact that async scheduler's timing appears to be less solid in Firefox.
      Adds support to Scheduler for converting between units (currently seconds and beats).
      Temporarily adds flock.component() prior to a move to Fluid Infusion.
      Adds support for removing individual Scheduler listeners.
      Resolves gh-25 with more unit tests for Myles' fix to scheduler.clearRepeat/clearAll().
      Refactored code for clearing events bound to interval workers.  Wrote unit test for async.repeat()... these tests are failing showing that more work is needed
      Updated Scheduler to release events on .clearRepeat()
      Renames conductor to scheduler; adds new scheduling functions.
      Fixes gh-24. Styles button lists in demos to be fully clickable. This solution uses CSS to style the anchors correctly, rather than using invalid markup.
      Updates to latest version of sheep.js with support for min/max.
      Updates the Flocking README to reflect new browser support and to do list.
      Removes Sheep.js from the repository in favour of a submodule.
      Removes PolyDataView from the flocking repository in favour of a submodule.
      Adds license files for PolyDataView in preparation for a move to its own repo.
      Minor comment updates.
      Minor tweaks to comments and naming in PolyDataview.
      Renames dataview.js to PolyDataview.
      Refactors and improves the Sheep benchmarking library--ready for use now.
      ...
    
    Conflicts:
    	flocking/flocking-ugens.js
    	tests/flocking/js/flocking-test-utils.js
    448017a
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment