Skip to content
This repository

Made change to /demos/index.html #24

Closed
wants to merge 1 commit into from

2 participants

Myles Borins Colin Clark
Myles Borins

Moved

elements into the links to make entire area clickable
Colin Clark colinbdclark closed this pull request from a commit August 12, 2012
Colin Clark Fixes gh-24. Styles button lists in demos to be fully clickable.
This solution uses CSS to style the anchors correctly, rather than using invalid markup.
42baa0b
Colin Clark colinbdclark closed this in 42baa0b August 12, 2012
Colin Clark colinbdclark referenced this pull request from a commit August 12, 2012
Colin Clark Merge branch 'button-list'
* button-list:
  Fixes gh-24. Styles button lists in demos to be fully clickable. This solution uses CSS to style the anchors correctly, rather than using invalid markup.
9acac59
Colin Clark
Owner

Myles,

Thanks very much for the pull request. Your solution solved the problem, but it introduced invalid HTML markup. You can't nest anchors directly within a

    or
    tag; they have to be within the
  1. .

    Instead, I resolved this issue by improving the CSS for the demos. Thanks for bringing the issue up and giving me some incentive to fix it!

Colin Clark colinbdclark referenced this pull request from a commit September 03, 2012
Colin Clark Merge branch 'master' into synth-groups
* master:
  Adds support to Scheduler for converting between units (currently seconds and beats).
  Temporarily adds flock.component() prior to a move to Fluid Infusion.
  Adds support for removing individual Scheduler listeners.
  Resolves gh-25 with more unit tests for Myles' fix to scheduler.clearRepeat/clearAll().
  Refactored code for clearing events bound to interval workers.  Wrote unit test for async.repeat()... these tests are failing showing that more work is needed
  Updated Scheduler to release events on .clearRepeat()
  Renames conductor to scheduler; adds new scheduling functions.
  Fixes gh-24. Styles button lists in demos to be fully clickable. This solution uses CSS to style the anchors correctly, rather than using invalid markup.
  Updates to latest version of sheep.js with support for min/max.
0809f0d
Colin Clark colinbdclark referenced this pull request from a commit September 05, 2012
Colin Clark Merged master and updated impulse to standard ugen idioms.
Merge branch 'master' into impulse

* master: (70 commits)
  Fixes bugs in beat scheduler.
  Improves factoring of time converters in the Scheduler.
  Increases tolerance for mistimed events in the Scheduler's unit tests. This is due to the fact that async scheduler's timing appears to be less solid in Firefox.
  Adds support to Scheduler for converting between units (currently seconds and beats).
  Temporarily adds flock.component() prior to a move to Fluid Infusion.
  Adds support for removing individual Scheduler listeners.
  Resolves gh-25 with more unit tests for Myles' fix to scheduler.clearRepeat/clearAll().
  Refactored code for clearing events bound to interval workers.  Wrote unit test for async.repeat()... these tests are failing showing that more work is needed
  Updated Scheduler to release events on .clearRepeat()
  Renames conductor to scheduler; adds new scheduling functions.
  Fixes gh-24. Styles button lists in demos to be fully clickable. This solution uses CSS to style the anchors correctly, rather than using invalid markup.
  Updates to latest version of sheep.js with support for min/max.
  Updates the Flocking README to reflect new browser support and to do list.
  Removes Sheep.js from the repository in favour of a submodule.
  Removes PolyDataView from the flocking repository in favour of a submodule.
  Adds license files for PolyDataView in preparation for a move to its own repo.
  Minor comment updates.
  Minor tweaks to comments and naming in PolyDataview.
  Renames dataview.js to PolyDataview.
  Refactors and improves the Sheep benchmarking library--ready for use now.
  ...

Conflicts:
	flocking/flocking-ugens.js
	tests/flocking/js/flocking-test-utils.js
448017a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Aug 07, 2012
Myles Borins Changed order of <li> and <a> in demo index.html to make entire eleme…
…nt part of the link
6437e66
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 12 additions and 12 deletions. Show diff stats Hide diff stats

  1. 24  demos/index.html
24  demos/index.html
@@ -10,18 +10,18 @@
10 10
         <h1>Flocking Demos</h1>
11 11
         
12 12
         <div class="demos">
13  
-    	    <ul>
14  
-    		    <li>
15  
-    		        <a href="interactive/html/playground.html">
16  
-                        Interactive Synthesis Environment
17  
-    		        </a>
18  
-    		    </li>
19  
-    		    <li>
20  
-            		<a href="audio-file/html/audiofile.html">
21  
-            			Decoding Audio Files
22  
-            		</a>
23  
-    		    </li>
24  
-    		</ul>
  13
+            <ul>
  14
+                <a href="interactive/html/playground.html">
  15
+                    <li>
  16
+                    Interactive Synthesis Environment
  17
+                    </li>
  18
+                </a>
  19
+                <a href="audio-file/html/audiofile.html">
  20
+                    <li>
  21
+                    Decoding Audio Files
  22
+                    </li>
  23
+                </a>
  24
+            </ul>
25 25
         </div>
26 26
     </body>
27 27
 </html>
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.