Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Auto Expiry Feature #111
Conversation
mpchadwick
added some commits
Sep 15, 2016
| */ | ||
| protected function _getAutoExpiringLifetime($lifetime, $id) | ||
| { | ||
| if ($lifetime) { |
This comment has been minimized.
This comment has been minimized.
colinmollenhour
Oct 1, 2016
Owner
No reason to check if it matches the pattern if the feature is disabled. I recommend short-circuiting by changing this to:
if ($lifetime || ! $this->_autoExpireLifetime) {
This comment has been minimized.
This comment has been minimized.
| return !empty($matches); | ||
| } | ||
|
|
||
| public function setAutoExpireLifetime($lifetime) |
This comment has been minimized.
This comment has been minimized.
colinmollenhour
Oct 1, 2016
•
Owner
Other options are not exposed this way... Is there a reason they need to be set aside from the constructor?
This comment has been minimized.
This comment has been minimized.
mpchadwick
Oct 1, 2016
Contributor
The reason I added the setters was to be able to change the properties for testAutoExpiry. Maybe there's a better way, but I'm not sure. I tried Googling to see if setUp could tell what test method as being called, but couldn't find any information about that.
This comment has been minimized.
This comment has been minimized.
colinmollenhour
Oct 3, 2016
Owner
I think the proper way would be to have a new test case class for these tests that require a different setUp method.
This comment has been minimized.
This comment has been minimized.
mpchadwick
Oct 3, 2016
Contributor
@colinmollenhour Updated with a separate test case. I'm following the pattern introduced with forceStandalone where a protected property is used and can be changed in the new test case class. Happy to squash these down as a final step if you'd like.
colinmollenhour
merged commit 155f4dc
into
colinmollenhour:master
Oct 3, 2016
This comment has been minimized.
This comment has been minimized.
|
Looks good! Thanks, Max! |
mpchadwick commentedOct 1, 2016
Implementation of feature discussed in #110.