New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto Expiry Feature #111

Merged
merged 6 commits into from Oct 3, 2016

Conversation

Projects
None yet
2 participants
@mpchadwick
Contributor

mpchadwick commented Oct 1, 2016

Implementation of feature discussed in #110.

*/
protected function _getAutoExpiringLifetime($lifetime, $id)
{
if ($lifetime) {

This comment has been minimized.

@colinmollenhour

colinmollenhour Oct 1, 2016

Owner

No reason to check if it matches the pattern if the feature is disabled. I recommend short-circuiting by changing this to:

 if ($lifetime || ! $this->_autoExpireLifetime) {

This comment has been minimized.

@mpchadwick

mpchadwick Oct 1, 2016

Contributor

Good call. Done.

return !empty($matches);
}

public function setAutoExpireLifetime($lifetime)

This comment has been minimized.

@colinmollenhour

colinmollenhour Oct 1, 2016

Owner

Other options are not exposed this way... Is there a reason they need to be set aside from the constructor?

This comment has been minimized.

@mpchadwick

mpchadwick Oct 1, 2016

Contributor

The reason I added the setters was to be able to change the properties for testAutoExpiry. Maybe there's a better way, but I'm not sure. I tried Googling to see if setUp could tell what test method as being called, but couldn't find any information about that.

This comment has been minimized.

@colinmollenhour

colinmollenhour Oct 3, 2016

Owner

I think the proper way would be to have a new test case class for these tests that require a different setUp method.

This comment has been minimized.

@mpchadwick

mpchadwick Oct 3, 2016

Contributor

@colinmollenhour Updated with a separate test case. I'm following the pattern introduced with forceStandalone where a protected property is used and can be changed in the new test case class. Happy to squash these down as a final step if you'd like.

@colinmollenhour colinmollenhour merged commit 155f4dc into colinmollenhour:master Oct 3, 2016

@colinmollenhour

This comment has been minimized.

Owner

colinmollenhour commented Oct 3, 2016

Looks good! Thanks, Max!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment